lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 124/717] media: v4l2-fwnode: v4l2_fwnode_endpoint_parse caller must init vep argument
    Date
    From: Sakari Ailus <sakari.ailus@linux.intel.com>

    [ Upstream commit b3cc73d2bf14e7c6e0376fa9433e708349e9ddfc ]

    Document that the caller of v4l2_fwnode_endpoint_parse() must init the
    fields of struct v4l2_fwnode_endpoint (vep argument) fields.

    It used to be that the fields were zeroed by v4l2_fwnode_endpoint_parse
    when bus type was set to V4L2_MBUS_UNKNOWN but with recent changes (Fixes:
    line below) that no longer makes sense.

    Fixes: bb4bba9232fc ("media: v4l2-fwnode: Make bus configuration a struct")
    Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
    Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
    Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    include/media/v4l2-fwnode.h | 6 ++++++
    1 file changed, 6 insertions(+)

    diff --git a/include/media/v4l2-fwnode.h b/include/media/v4l2-fwnode.h
    index c090742765431..ed0840f3d5dff 100644
    --- a/include/media/v4l2-fwnode.h
    +++ b/include/media/v4l2-fwnode.h
    @@ -231,6 +231,9 @@ struct v4l2_fwnode_connector {
    * guessing @vep.bus_type between CSI-2 D-PHY, parallel and BT.656 busses is
    * supported. NEVER RELY ON GUESSING @vep.bus_type IN NEW DRIVERS!
    *
    + * The caller is required to initialise all fields of @vep, either with
    + * explicitly values, or by zeroing them.
    + *
    * The function does not change the V4L2 fwnode endpoint state if it fails.
    *
    * NOTE: This function does not parse properties the size of which is variable
    @@ -273,6 +276,9 @@ void v4l2_fwnode_endpoint_free(struct v4l2_fwnode_endpoint *vep);
    * guessing @vep.bus_type between CSI-2 D-PHY, parallel and BT.656 busses is
    * supported. NEVER RELY ON GUESSING @vep.bus_type IN NEW DRIVERS!
    *
    + * The caller is required to initialise all fields of @vep, either with
    + * explicitly values, or by zeroing them.
    + *
    * The function does not change the V4L2 fwnode endpoint state if it fails.
    *
    * v4l2_fwnode_endpoint_alloc_parse() has two important differences to
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:07    [W:2.220 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site