lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 119/717] media: platform: add missing put_device() call in mtk_jpeg_clk_init()
    Date
    From: Yu Kuai <yukuai3@huawei.com>

    [ Upstream commit f28a81a3b64270da3588174feff4628c36e0ff4e ]

    if of_find_device_by_node() succeeds, mtk_jpeg_clk_init() doesn't have
    a corresponding put_device(). Thus add put_device() to fix the exception
    handling for this function implementation.

    Fixes: 648372a87cee ("media: platform: Change the call functions of getting/enable/disable the jpeg's clock")
    Signed-off-by: Yu Kuai <yukuai3@huawei.com>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
    index 227245ccaedc7..106543391c460 100644
    --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
    +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
    @@ -1306,6 +1306,7 @@ static int mtk_jpeg_clk_init(struct mtk_jpeg_dev *jpeg)
    jpeg->variant->clks);
    if (ret) {
    dev_err(&pdev->dev, "failed to get jpeg clock:%d\n", ret);
    + put_device(&pdev->dev);
    return ret;
    }

    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:07    [W:4.014 / U:0.848 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site