lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 079/717] spi: tegra20-sflash: fix reference leak in tegra_sflash_resume
    Date
    From: Zhang Qilong <zhangqilong3@huawei.com>

    [ Upstream commit 3482e797ab688da6703fe18d8bad52f94199f4f2 ]

    pm_runtime_get_sync will increment pm usage counter even it
    failed. Forgetting to pm_runtime_put_noidle will result in
    reference leak in tegra_sflash_resume, so we should fix it.

    Fixes: 8528547bcc336 ("spi: tegra: add spi driver for sflash controller")
    Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
    Link: https://lore.kernel.org/r/20201103141323.5841-1-zhangqilong3@huawei.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/spi/spi-tegra20-sflash.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/spi/spi-tegra20-sflash.c b/drivers/spi/spi-tegra20-sflash.c
    index b59015c7c8a80..cfb7de7379376 100644
    --- a/drivers/spi/spi-tegra20-sflash.c
    +++ b/drivers/spi/spi-tegra20-sflash.c
    @@ -552,6 +552,7 @@ static int tegra_sflash_resume(struct device *dev)

    ret = pm_runtime_get_sync(dev);
    if (ret < 0) {
    + pm_runtime_put_noidle(dev);
    dev_err(dev, "pm runtime failed, e = %d\n", ret);
    return ret;
    }
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:07    [W:4.146 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site