lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 035/717] crypto: talitos - Fix return type of current_desc_hdr()
    Date
    From: Christophe Leroy <christophe.leroy@csgroup.eu>

    [ Upstream commit 0237616173fd363a54bd272aa3bd376faa1d7caa ]

    current_desc_hdr() returns a u32 but in fact this is a __be32,
    leading to a lot of sparse warnings.

    Change the return type to __be32 and ensure it is handled as
    sure by the caller.

    Fixes: 3e721aeb3df3 ("crypto: talitos - handle descriptor not found in error path")
    Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/crypto/talitos.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
    index 1de6b01381268..a713a35dc5022 100644
    --- a/drivers/crypto/talitos.c
    +++ b/drivers/crypto/talitos.c
    @@ -460,7 +460,7 @@ DEF_TALITOS2_DONE(ch1_3, TALITOS2_ISR_CH_1_3_DONE)
    /*
    * locate current (offending) descriptor
    */
    -static u32 current_desc_hdr(struct device *dev, int ch)
    +static __be32 current_desc_hdr(struct device *dev, int ch)
    {
    struct talitos_private *priv = dev_get_drvdata(dev);
    int tail, iter;
    @@ -501,13 +501,13 @@ static u32 current_desc_hdr(struct device *dev, int ch)
    /*
    * user diagnostics; report root cause of error based on execution unit status
    */
    -static void report_eu_error(struct device *dev, int ch, u32 desc_hdr)
    +static void report_eu_error(struct device *dev, int ch, __be32 desc_hdr)
    {
    struct talitos_private *priv = dev_get_drvdata(dev);
    int i;

    if (!desc_hdr)
    - desc_hdr = in_be32(priv->chan[ch].reg + TALITOS_DESCBUF);
    + desc_hdr = cpu_to_be32(in_be32(priv->chan[ch].reg + TALITOS_DESCBUF));

    switch (desc_hdr & DESC_HDR_SEL0_MASK) {
    case DESC_HDR_SEL0_AFEU:
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:05    [W:4.066 / U:0.520 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site