lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 006/717] drm/tve200: Fix handling of platform_get_irq() error
    Date
    From: Krzysztof Kozlowski <krzk@kernel.org>

    [ Upstream commit 77bb5aaf2bb8180e7d1bb70b4df306f511707a7d ]

    platform_get_irq() returns -ERRNO on error. In such case comparison
    to 0 would pass the check.

    Fixes: 179c02fe90a4 ("drm/tve200: Add new driver for TVE200")
    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    Acked-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
    Link: https://patchwork.freedesktop.org/patch/msgid/20200827071107.27429-2-krzk@kernel.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/tve200/tve200_drv.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/tve200/tve200_drv.c b/drivers/gpu/drm/tve200/tve200_drv.c
    index c3aa39bd38ecd..b5259cb1383fc 100644
    --- a/drivers/gpu/drm/tve200/tve200_drv.c
    +++ b/drivers/gpu/drm/tve200/tve200_drv.c
    @@ -200,8 +200,8 @@ static int tve200_probe(struct platform_device *pdev)
    }

    irq = platform_get_irq(pdev, 0);
    - if (!irq) {
    - ret = -EINVAL;
    + if (irq < 0) {
    + ret = irq;
    goto clk_disable;
    }

    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:01    [W:2.213 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site