lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 250/453] usb: ehci-omap: Fix PM disable depth umbalance in ehci_hcd_omap_probe
    Date
    From: Zhang Qilong <zhangqilong3@huawei.com>

    [ Upstream commit d6ff32478d7e95d6ca199b5c852710d6964d5811 ]

    The pm_runtime_enable will decrement the power disable depth. Imbalance
    depth will resulted in enabling runtime PM of device fails later. Thus
    a pairing decrement must be needed on the error handling path to keep it
    balanced.

    Fixes: 6c984b066d84b ("ARM: OMAP: USBHOST: Replace usbhs core driver APIs by Runtime pm APIs")
    Acked-by: Alan Stern <stern@rowland.harvard.edu>
    Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
    Link: https://lore.kernel.org/r/20201123145719.1455849-1-zhangqilong3@huawei.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/host/ehci-omap.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
    index fc125b3d06e7d..03122dc332eda 100644
    --- a/drivers/usb/host/ehci-omap.c
    +++ b/drivers/usb/host/ehci-omap.c
    @@ -220,6 +220,7 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)

    err_pm_runtime:
    pm_runtime_put_sync(dev);
    + pm_runtime_disable(dev);

    err_phy:
    for (i = 0; i < omap->nports; i++) {
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 14:49    [W:3.097 / U:0.648 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site