lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 163/242] powerpc/ps3: use dma_mapping_error()
    Date
    From: Vincent Stehlé <vincent.stehle@laposte.net>

    [ Upstream commit d0edaa28a1f7830997131cbce87b6c52472825d1 ]

    The DMA address returned by dma_map_single() should be checked with
    dma_mapping_error(). Fix the ps3stor_setup() function accordingly.

    Fixes: 80071802cb9c ("[POWERPC] PS3: Storage Driver Core")
    Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
    Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20201213182622.23047-1-vincent.stehle@laposte.net
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/ps3/ps3stor_lib.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/ps3/ps3stor_lib.c b/drivers/ps3/ps3stor_lib.c
    index 8c3f5adf1bc65..2d76183756626 100644
    --- a/drivers/ps3/ps3stor_lib.c
    +++ b/drivers/ps3/ps3stor_lib.c
    @@ -201,7 +201,7 @@ int ps3stor_setup(struct ps3_storage_device *dev, irq_handler_t handler)
    dev->bounce_lpar = ps3_mm_phys_to_lpar(__pa(dev->bounce_buf));
    dev->bounce_dma = dma_map_single(&dev->sbd.core, dev->bounce_buf,
    dev->bounce_size, DMA_BIDIRECTIONAL);
    - if (!dev->bounce_dma) {
    + if (dma_mapping_error(&dev->sbd.core, dev->bounce_dma)) {
    dev_err(&dev->sbd.core, "%s:%u: map DMA region failed\n",
    __func__, __LINE__);
    error = -ENODEV;
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 14:16    [W:3.269 / U:0.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site