Messages in this thread | | | Date | Mon, 28 Dec 2020 18:24:30 -0500 | From | Sasha Levin <> | Subject | Re: [PATCH 5.10 098/717] net: evaluate net.ipvX.conf.all.ignore_routes_with_linkdown |
| |
On Mon, Dec 28, 2020 at 10:50:58AM -0800, Jakub Kicinski wrote: >On Mon, 28 Dec 2020 13:41:36 +0100 Greg Kroah-Hartman wrote: >> From: Vincent Bernat <vincent@bernat.ch> >> >> [ Upstream commit c0c5a60f0f1311bcf08bbe735122096d6326fb5b ] >> >> Introduced in 0eeb075fad73, the "ignore_routes_with_linkdown" sysctl >> ignores a route whose interface is down. It is provided as a >> per-interface sysctl. However, while a "all" variant is exposed, it >> was a noop since it was never evaluated. We use the usual "or" logic >> for this kind of sysctls. > >I'd recommend to drop 98 and 99, at least for now. > >The kernel always behaved this way, and it remains to be seen if anyone >depended on that (mis) behavior. > >This needs to hit a real release.
I'll drop it.
-- Thanks, Sasha
| |