lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 025/242] USB: dummy-hcd: Fix uninitialized array use in init()
    Date
    From: Bui Quang Minh <minhquangbui99@gmail.com>

    commit e90cfa813da7a527785033a0b247594c2de93dd8 upstream.

    This error path

    err_add_pdata:
    for (i = 0; i < mod_data.num; i++)
    kfree(dum[i]);

    can be triggered when not all dum's elements are initialized.

    Fix this by initializing all dum's elements to NULL.

    Acked-by: Alan Stern <stern@rowland.harvard.edu>
    Cc: stable <stable@vger.kernel.org>
    Signed-off-by: Bui Quang Minh <minhquangbui99@gmail.com>
    Link: https://lore.kernel.org/r/1607063090-3426-1-git-send-email-minhquangbui99@gmail.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/gadget/udc/dummy_hcd.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/usb/gadget/udc/dummy_hcd.c
    +++ b/drivers/usb/gadget/udc/dummy_hcd.c
    @@ -2742,7 +2742,7 @@ static int __init init(void)
    {
    int retval = -ENOMEM;
    int i;
    - struct dummy *dum[MAX_NUM_UDC];
    + struct dummy *dum[MAX_NUM_UDC] = {};

    if (usb_disabled())
    return -ENODEV;

    \
     
     \ /
      Last update: 2020-12-28 17:27    [W:6.836 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site