lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 011/453] gpio: zynq: fix reference leak in zynq_gpio functions
    Date
    From: Qinglang Miao <miaoqinglang@huawei.com>

    [ Upstream commit 7f57b295f990c0fa07f96d51ca1c82c52dbf79cc ]

    pm_runtime_get_sync will increment pm usage counter even it
    failed. Forgetting to putting operation will result in a
    reference leak here.

    A new function pm_runtime_resume_and_get is introduced in
    [0] to keep usage counter balanced. So We fix the reference
    leak by replacing it with new funtion.

    [0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")

    Fixes: c2df3de0d07e ("gpio: zynq: properly support runtime PM for GPIO used as interrupts")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
    Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpio/gpio-zynq.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c
    index 7835aad6d1628..88b04d8a7fa7d 100644
    --- a/drivers/gpio/gpio-zynq.c
    +++ b/drivers/gpio/gpio-zynq.c
    @@ -556,7 +556,7 @@ static int zynq_gpio_irq_reqres(struct irq_data *d)
    struct gpio_chip *chip = irq_data_get_irq_chip_data(d);
    int ret;

    - ret = pm_runtime_get_sync(chip->parent);
    + ret = pm_runtime_resume_and_get(chip->parent);
    if (ret < 0)
    return ret;

    @@ -884,7 +884,7 @@ static int zynq_gpio_probe(struct platform_device *pdev)

    pm_runtime_set_active(&pdev->dev);
    pm_runtime_enable(&pdev->dev);
    - ret = pm_runtime_get_sync(&pdev->dev);
    + ret = pm_runtime_resume_and_get(&pdev->dev);
    if (ret < 0)
    goto err_pm_dis;

    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 16:53    [W:2.448 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site