lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 040/717] drm/amdgpu: fix build_coefficients() argument
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    [ Upstream commit dbb60031dd0c2b85f10ce4c12ae604c28d3aaca4 ]

    gcc -Wextra warns about a function taking an enum argument
    being called with a bool:

    drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_gamma.c: In function 'apply_degamma_for_user_regamma':
    drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_gamma.c:1617:29: warning: implicit conversion from 'enum <anonymous>' to 'enum dc_transfer_func_predefined' [-Wenum-conversion]
    1617 | build_coefficients(&coeff, true);

    It appears that a patch was added using the old calling conventions
    after the type was changed, and the value should actually be 0
    (TRANSFER_FUNCTION_SRGB) here instead of 1 (true).

    Fixes: 55a01d4023ce ("drm/amd/display: Add user_regamma to color module")
    Reviewed-by: Harry Wentland <harry.wentland@amd.com>
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/amd/display/modules/color/color_gamma.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/amd/display/modules/color/color_gamma.c b/drivers/gpu/drm/amd/display/modules/color/color_gamma.c
    index b8695660b480e..09bc2c249e1af 100644
    --- a/drivers/gpu/drm/amd/display/modules/color/color_gamma.c
    +++ b/drivers/gpu/drm/amd/display/modules/color/color_gamma.c
    @@ -1614,7 +1614,7 @@ static void apply_degamma_for_user_regamma(struct pwl_float_data_ex *rgb_regamma
    struct pwl_float_data_ex *rgb = rgb_regamma;
    const struct hw_x_point *coord_x = coordinates_x;

    - build_coefficients(&coeff, true);
    + build_coefficients(&coeff, TRANSFER_FUNCTION_SRGB);

    i = 0;
    while (i != hw_points_num + 1) {
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 16:23    [W:2.636 / U:1.432 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site