lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 054/717] drm/bridge: tpd12s015: Fix irq registering in tpd12s015_probe
    Date
    From: YueHaibing <yuehaibing@huawei.com>

    [ Upstream commit c2530cc9610d84a5a0118ba40d0f09309605047f ]

    gpiod_to_irq() return negative value in case of error,
    the existing code doesn't handle negative error codes.
    If the HPD gpio supports IRQs (gpiod_to_irq returns a
    valid number), we use the IRQ. If it doesn't (gpiod_to_irq
    returns an error), it gets polled via detect().

    Fixes: cff5e6f7e83f ("drm/bridge: Add driver for the TI TPD12S015 HDMI level shifter")
    Signed-off-by: YueHaibing <yuehaibing@huawei.com>
    Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
    Link: https://patchwork.freedesktop.org/patch/msgid/20201102143024.26216-1-yuehaibing@huawei.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/bridge/ti-tpd12s015.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/bridge/ti-tpd12s015.c b/drivers/gpu/drm/bridge/ti-tpd12s015.c
    index 514cbf0eac75a..e0e015243a602 100644
    --- a/drivers/gpu/drm/bridge/ti-tpd12s015.c
    +++ b/drivers/gpu/drm/bridge/ti-tpd12s015.c
    @@ -160,7 +160,7 @@ static int tpd12s015_probe(struct platform_device *pdev)

    /* Register the IRQ if the HPD GPIO is IRQ-capable. */
    tpd->hpd_irq = gpiod_to_irq(tpd->hpd_gpio);
    - if (tpd->hpd_irq) {
    + if (tpd->hpd_irq >= 0) {
    ret = devm_request_threaded_irq(&pdev->dev, tpd->hpd_irq, NULL,
    tpd12s015_hpd_isr,
    IRQF_TRIGGER_RISING |
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 16:23    [W:4.053 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site