lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 050/717] spi: spi-mem: fix reference leak in spi_mem_access_start
    Date
    From: Zhang Qilong <zhangqilong3@huawei.com>

    [ Upstream commit c02bb16b0e826bf0e19aa42c3ae60ea339f32cf5 ]

    pm_runtime_get_sync will increment pm usage counter even it
    failed. Forgetting to pm_runtime_put_noidle will result in
    reference leak in spi_mem_access_start, so we should fix it.

    Fixes: f86c24f479530 ("spi: spi-mem: Split spi_mem_exec_op() code")
    Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
    Link: https://lore.kernel.org/r/20201103140910.3482-1-zhangqilong3@huawei.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/spi/spi-mem.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/spi/spi-mem.c b/drivers/spi/spi-mem.c
    index ef53290b7d24d..4682f49dc7330 100644
    --- a/drivers/spi/spi-mem.c
    +++ b/drivers/spi/spi-mem.c
    @@ -243,6 +243,7 @@ static int spi_mem_access_start(struct spi_mem *mem)

    ret = pm_runtime_get_sync(ctlr->dev.parent);
    if (ret < 0) {
    + pm_runtime_put_noidle(ctlr->dev.parent);
    dev_err(&ctlr->dev, "Failed to power device: %d\n",
    ret);
    return ret;
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 16:21    [W:4.218 / U:1.776 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site