lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 165/717] scsi: ufs: Avoid to call REQ_CLKS_OFF to CLKS_OFF
    Date
    From: Jaegeuk Kim <jaegeuk@kernel.org>

    [ Upstream commit fd62de114f8c9df098dcd43b5d83c5714176dd12 ]

    Once UFS is gated with CLKS_OFF, it should not call REQ_CLKS_OFF
    again. This can lead to hibern8_enter failure.

    Link: https://lore.kernel.org/r/20201117165839.1643377-2-jaegeuk@kernel.org
    Reviewed-by: Can Guo <cang@codeaurora.org>
    Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/ufs/ufshcd.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
    index 0c148fcd24deb..1ad7d6c130f5b 100644
    --- a/drivers/scsi/ufs/ufshcd.c
    +++ b/drivers/scsi/ufs/ufshcd.c
    @@ -1752,7 +1752,8 @@ static void __ufshcd_release(struct ufs_hba *hba)
    if (hba->clk_gating.active_reqs || hba->clk_gating.is_suspended ||
    hba->ufshcd_state != UFSHCD_STATE_OPERATIONAL ||
    ufshcd_any_tag_in_use(hba) || hba->outstanding_tasks ||
    - hba->active_uic_cmd || hba->uic_async_done)
    + hba->active_uic_cmd || hba->uic_async_done ||
    + hba->clk_gating.state == CLKS_OFF)
    return;

    hba->clk_gating.state = REQ_CLKS_OFF;
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 16:13    [W:2.044 / U:1.512 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site