lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 171/717] crypto: omap-aes - Fix PM disable depth imbalance in omap_aes_probe
    Date
    From: Zhang Qilong <zhangqilong3@huawei.com>

    [ Upstream commit ff8107200367f4abe0e5bce66a245e8d0f2d229e ]

    The pm_runtime_enable will increase power disable depth.
    Thus a pairing decrement is needed on the error handling
    path to keep it balanced according to context.

    Fixes: f7b2b5dd6a62a ("crypto: omap-aes - add error check for pm_runtime_get_sync")
    Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/crypto/omap-aes.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
    index 4fd14d90cc409..1b1e0ab0a831a 100644
    --- a/drivers/crypto/omap-aes.c
    +++ b/drivers/crypto/omap-aes.c
    @@ -1137,7 +1137,7 @@ static int omap_aes_probe(struct platform_device *pdev)
    if (err < 0) {
    dev_err(dev, "%s: failed to get_sync(%d)\n",
    __func__, err);
    - goto err_res;
    + goto err_pm_disable;
    }

    omap_aes_dma_stop(dd);
    @@ -1246,6 +1246,7 @@ err_engine:
    omap_aes_dma_cleanup(dd);
    err_irq:
    tasklet_kill(&dd->done_task);
    +err_pm_disable:
    pm_runtime_disable(dev);
    err_res:
    dd = NULL;
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 16:12    [W:2.716 / U:0.688 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site