lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 277/717] media: tvp5150: Fix wrong return value of tvp5150_parse_dt()
    Date
    From: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>

    [ Upstream commit eb08c48132a1f594478ab9fa2b6ee646c3513a49 ]

    If of_graph_get_endpoint_by_regs() return NULL, it will return 0 rather
    than an errno, because we doesn't initialize the return value.

    Fixes: 0556f1d580d4 ("media: tvp5150: add input source selection of_graph support")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
    Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/i2c/tvp5150.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
    index 7d9401219a3ac..3b3221fd3fe8f 100644
    --- a/drivers/media/i2c/tvp5150.c
    +++ b/drivers/media/i2c/tvp5150.c
    @@ -2082,6 +2082,7 @@ static int tvp5150_parse_dt(struct tvp5150 *decoder, struct device_node *np)

    ep_np = of_graph_get_endpoint_by_regs(np, TVP5150_PAD_VID_OUT, 0);
    if (!ep_np) {
    + ret = -EINVAL;
    dev_err(dev, "Error no output endpoint available\n");
    goto err_free;
    }
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 16:09    [W:4.167 / U:1.340 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site