lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 332/717] cpufreq: imx: fix NVMEM_IMX_OCOTP dependency
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    [ Upstream commit fc928b901dc68481ba3e524860a641fe13e25dfe ]

    A driver should not 'select' drivers from another subsystem.
    If NVMEM is disabled, this one results in a warning:

    WARNING: unmet direct dependencies detected for NVMEM_IMX_OCOTP
    Depends on [n]: NVMEM [=n] && (ARCH_MXC [=y] || COMPILE_TEST [=y]) && HAS_IOMEM [=y]
    Selected by [y]:
    - ARM_IMX6Q_CPUFREQ [=y] && CPU_FREQ [=y] && (ARM || ARM64 [=y]) && ARCH_MXC [=y] && REGULATOR_ANATOP [=y]

    Change the 'select' to 'depends on' to prevent it from going wrong,
    and allow compile-testing without that driver, since it is only
    a runtime dependency.

    Fixes: 2782ef34ed23 ("cpufreq: imx: Select NVMEM_IMX_OCOTP")
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/cpufreq/Kconfig.arm | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
    index 015ec0c028358..1f73fa75b1a05 100644
    --- a/drivers/cpufreq/Kconfig.arm
    +++ b/drivers/cpufreq/Kconfig.arm
    @@ -94,7 +94,7 @@ config ARM_IMX6Q_CPUFREQ
    tristate "Freescale i.MX6 cpufreq support"
    depends on ARCH_MXC
    depends on REGULATOR_ANATOP
    - select NVMEM_IMX_OCOTP
    + depends on NVMEM_IMX_OCOTP || COMPILE_TEST
    select PM_OPP
    help
    This adds cpufreq driver support for Freescale i.MX6 series SoCs.
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:59    [W:2.309 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site