lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 355/717] clk: fsl-sai: fix memory leak
    Date
    From: Michael Walle <michael@walle.cc>

    [ Upstream commit e81bed419f032824e7ddf8b5630153be6637e480 ]

    If the device is removed we don't unregister the composite clock. Fix
    that.

    Fixes: 9cd10205227c ("clk: fsl-sai: new driver")
    Signed-off-by: Michael Walle <michael@walle.cc>
    Link: https://lore.kernel.org/r/20201105192746.19564-2-michael@walle.cc
    Signed-off-by: Stephen Boyd <sboyd@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/clk/clk-fsl-sai.c | 12 ++++++++++++
    1 file changed, 12 insertions(+)

    diff --git a/drivers/clk/clk-fsl-sai.c b/drivers/clk/clk-fsl-sai.c
    index 0221180a4dd73..1e81c8d8a6fd3 100644
    --- a/drivers/clk/clk-fsl-sai.c
    +++ b/drivers/clk/clk-fsl-sai.c
    @@ -68,9 +68,20 @@ static int fsl_sai_clk_probe(struct platform_device *pdev)
    if (IS_ERR(hw))
    return PTR_ERR(hw);

    + platform_set_drvdata(pdev, hw);
    +
    return devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get, hw);
    }

    +static int fsl_sai_clk_remove(struct platform_device *pdev)
    +{
    + struct clk_hw *hw = platform_get_drvdata(pdev);
    +
    + clk_hw_unregister_composite(hw);
    +
    + return 0;
    +}
    +
    static const struct of_device_id of_fsl_sai_clk_ids[] = {
    { .compatible = "fsl,vf610-sai-clock" },
    { }
    @@ -79,6 +90,7 @@ MODULE_DEVICE_TABLE(of, of_fsl_sai_clk_ids);

    static struct platform_driver fsl_sai_clk_driver = {
    .probe = fsl_sai_clk_probe,
    + .remove = fsl_sai_clk_remove,
    .driver = {
    .name = "fsl-sai-clk",
    .of_match_table = of_fsl_sai_clk_ids,
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:59    [W:2.913 / U:1.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site