lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 401/717] remoteproc: qcom: fix reference leak in adsp_start
    Date
    From: Zhang Qilong <zhangqilong3@huawei.com>

    [ Upstream commit aa37448f597c09844942da87d042fc6793f989c2 ]

    pm_runtime_get_sync will increment pm usage counter even it
    failed. Forgetting to pm_runtime_put_noidle will result in
    reference leak in adsp_start, so we should fix it.

    Fixes: dc160e4491222 ("remoteproc: qcom: Introduce Non-PAS ADSP PIL driver")
    Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
    Link: https://lore.kernel.org/r/20201102143534.144484-1-zhangqilong3@huawei.com
    Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/remoteproc/qcom_q6v5_adsp.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c
    index efb2c1aa80a3c..f0b7363b5b268 100644
    --- a/drivers/remoteproc/qcom_q6v5_adsp.c
    +++ b/drivers/remoteproc/qcom_q6v5_adsp.c
    @@ -193,8 +193,10 @@ static int adsp_start(struct rproc *rproc)

    dev_pm_genpd_set_performance_state(adsp->dev, INT_MAX);
    ret = pm_runtime_get_sync(adsp->dev);
    - if (ret)
    + if (ret) {
    + pm_runtime_put_noidle(adsp->dev);
    goto disable_xo_clk;
    + }

    ret = clk_bulk_prepare_enable(adsp->num_clks, adsp->clks);
    if (ret) {
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:53    [W:4.065 / U:2.836 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site