lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 492/717] vhost scsi: fix error return code in vhost_scsi_set_endpoint()
    Date
    From: Zhang Changzhong <zhangchangzhong@huawei.com>

    [ Upstream commit 2e1139d613c7fb0956e82f72a8281c0a475ad4f8 ]

    Fix to return a negative error code from the error handling
    case instead of 0, as done elsewhere in this function.

    Fixes: 25b98b64e284 ("vhost scsi: alloc cmds per vq instead of session")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
    Link: https://lore.kernel.org/r/1607071411-33484-1-git-send-email-zhangchangzhong@huawei.com
    Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/vhost/scsi.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
    index 6ff8a50966915..4ce9f00ae10e8 100644
    --- a/drivers/vhost/scsi.c
    +++ b/drivers/vhost/scsi.c
    @@ -1643,7 +1643,8 @@ vhost_scsi_set_endpoint(struct vhost_scsi *vs,
    if (!vhost_vq_is_setup(vq))
    continue;

    - if (vhost_scsi_setup_vq_cmds(vq, vq->num))
    + ret = vhost_scsi_setup_vq_cmds(vq, vq->num);
    + if (ret)
    goto destroy_vq_cmds;
    }

    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:48    [W:3.037 / U:0.268 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site