lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 477/717] watchdog: coh901327: add COMMON_CLK dependency
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    [ Upstream commit 36c47df85ee8e1f8a35366ac11324f8875de00eb ]

    clang produces a build failure in configurations without COMMON_CLK
    when a timeout calculation goes wrong:

    arm-linux-gnueabi-ld: drivers/watchdog/coh901327_wdt.o: in function `coh901327_enable':
    coh901327_wdt.c:(.text+0x50): undefined reference to `__bad_udelay'

    Add a Kconfig dependency to only do build testing when COMMON_CLK
    is enabled.

    Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible")
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Reviewed-by: Guenter Roeck <linux@roeck-us.net>
    Link: https://lore.kernel.org/r/20201203223358.1269372-1-arnd@kernel.org
    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/watchdog/Kconfig | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
    index f8e9be65036ae..db935d6b10c27 100644
    --- a/drivers/watchdog/Kconfig
    +++ b/drivers/watchdog/Kconfig
    @@ -632,7 +632,7 @@ config SUNXI_WATCHDOG

    config COH901327_WATCHDOG
    bool "ST-Ericsson COH 901 327 watchdog"
    - depends on ARCH_U300 || (ARM && COMPILE_TEST)
    + depends on ARCH_U300 || (ARM && COMMON_CLK && COMPILE_TEST)
    default y if MACH_U300
    select WATCHDOG_CORE
    help
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:48    [W:2.627 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site