lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 418/717] irqchip/alpine-msi: Fix freeing of interrupts on allocation error path
    Date
    From: Marc Zyngier <maz@kernel.org>

    [ Upstream commit 3841245e8498a789c65dedd7ffa8fb2fee2c0684 ]

    The alpine-msi driver has an interesting allocation error handling,
    where it frees the same interrupts repeatedly. Hilarity follows.

    This code is probably never executed, but let's fix it nonetheless.

    Fixes: e6b78f2c3e14 ("irqchip: Add the Alpine MSIX interrupt controller")
    Signed-off-by: Marc Zyngier <maz@kernel.org>
    Reviewed-by: Antoine Tenart <atenart@kernel.org>
    Cc: Tsahee Zidenberg <tsahee@annapurnalabs.com>
    Cc: Antoine Tenart <atenart@kernel.org>
    Link: https://lore.kernel.org/r/20201129135525.396671-1-maz@kernel.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/irqchip/irq-alpine-msi.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/irqchip/irq-alpine-msi.c b/drivers/irqchip/irq-alpine-msi.c
    index 23a3b877f7f1d..ede02dc2bcd0b 100644
    --- a/drivers/irqchip/irq-alpine-msi.c
    +++ b/drivers/irqchip/irq-alpine-msi.c
    @@ -165,8 +165,7 @@ static int alpine_msix_middle_domain_alloc(struct irq_domain *domain,
    return 0;

    err_sgi:
    - while (--i >= 0)
    - irq_domain_free_irqs_parent(domain, virq, i);
    + irq_domain_free_irqs_parent(domain, virq, i - 1);
    alpine_msix_free_sgi(priv, sgi, nr_irqs);
    return err;
    }
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:40    [W:3.431 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site