lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 702/717] memory: renesas-rpc-if: Fix a node reference leak in rpcif_probe()
    Date
    From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

    commit 4e6b86b409f9fc63fedb39d6e3a0202c4b0244ce upstream.

    Release the node reference by calling of_node_put(flash) in the probe.

    Fixes: ca7d8b980b67f ("memory: add Renesas RPC-IF driver")
    Reported-by: Pavel Machek <pavel@denx.de>
    Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
    Reviewed-by: Sergei Shtylyov <sergei.shtylyov@gmail.com>
    Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Reviewed-by: Pavel Machek (CIP) <pavel@denx.de>
    Cc: stable@vger.kernel.org
    Link: https://lore.kernel.org/r/20201126191146.8753-4-prabhakar.mahadev-lad.rj@bp.renesas.com
    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/memory/renesas-rpc-if.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/memory/renesas-rpc-if.c
    +++ b/drivers/memory/renesas-rpc-if.c
    @@ -560,9 +560,11 @@ static int rpcif_probe(struct platform_d
    } else if (of_device_is_compatible(flash, "cfi-flash")) {
    name = "rpc-if-hyperflash";
    } else {
    + of_node_put(flash);
    dev_warn(&pdev->dev, "unknown flash type\n");
    return -ENODEV;
    }
    + of_node_put(flash);

    vdev = platform_device_alloc(name, pdev->id);
    if (!vdev)

    \
     
     \ /
      Last update: 2020-12-28 15:39    [W:2.102 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site