Messages in this thread Patch in this message | | | From | "Wang, Xiaolei" <> | Subject | RE: [PATCH] regmap: debugfs: fix a memory leak when calling regmap_attach_dev | Date | Sun, 27 Dec 2020 12:18:16 +0000 |
| |
Hi Markus
> This should be caused by > commit <9b947a13e7f6> ("<regmap: use debugfs even when no device>")
> I suggest to omit angle brackets from such information.
> * Will another imperative wording become helpful for the commit description?
> * How do you think about to add the tag “Fixes”?
Do you mean so?
commit: 9b947a13e7f6 ("regmap: use debugfs even when no device")
… > +++ b/drivers/base/regmap/regmap-debugfs.c … > @@ -582,8 +582,10 @@ void regmap_debugfs_init(struct regmap *map) > devname = dev_name(map->dev); > > if (name) { > - map->debugfs_name = kasprintf(GFP_KERNEL, "%s-%s", > + if (!map->debugfs_name) { > + map->debugfs_name = kasprintf(GFP_KERNEL, "%s-%s", > devname, name); > + } …
> I propose to add another null pointer check together with corresponding exception handling.
Which one do you mean by "another null point"? Do you mean that if the call "regmap_debugfs_init" function is repeated, it returns directly?
Regards, Xiaolei
-----Original Message----- From: Markus Elfring <Markus.Elfring@web.de> Sent: Saturday, December 26, 2020 10:16 PM To: Wang, Xiaolei <Xiaolei.Wang@windriver.com>; kernel-janitors@vger.kernel.org Cc: linux-kernel@vger.kernel.org; Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Mark Brown <broonie@kernel.org>; Rafael J. Wysocki <rafael@kernel.org> Subject: Re: [PATCH] regmap: debugfs: fix a memory leak when calling regmap_attach_dev
> This should be caused by > commit <9b947a13e7f6> ("<regmap: use debugfs even when no device>")
I suggest to omit angle brackets from such information.
* Will another imperative wording become helpful for the commit description?
* How do you think about to add the tag “Fixes”?
… > +++ b/drivers/base/regmap/regmap-debugfs.c … > @@ -582,8 +582,10 @@ void regmap_debugfs_init(struct regmap *map) > devname = dev_name(map->dev); > > if (name) { > - map->debugfs_name = kasprintf(GFP_KERNEL, "%s-%s", > + if (!map->debugfs_name) { > + map->debugfs_name = kasprintf(GFP_KERNEL, "%s-%s", > devname, name); > + } …
I propose to add another null pointer check together with corresponding exception handling.
Regards, Markus
| |