Messages in this thread | | | Date | Sun, 27 Dec 2020 12:40:51 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] staging: android: ashmem: Fixed warning for structure declaration |
| |
On Sun, Dec 27, 2020 at 04:56:45PM +0530, Angshuman Sengupta wrote: > Warning found by checkpatch.pl script. > > Signed-off-by: Angshuman Sengupta <senguptaangshuman17@gmail.com> > --- > drivers/staging/android/ashmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c > index 4789d36ddfd3..2cb665e0228c 100644 > --- a/drivers/staging/android/ashmem.c > +++ b/drivers/staging/android/ashmem.c > @@ -376,7 +376,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr, > > static int ashmem_mmap(struct file *file, struct vm_area_struct *vma) > { > - static struct file_operations vmfile_fops; > + static const struct file_operations vmfile_fops; > struct ashmem_area *asma = file->private_data; > int ret = 0; >
Did you test build this change? Why not?
thanks,
greg k-h
| |