lkml.org 
[lkml]   [2020]   [Dec]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 07/15] phy: cadence: cadence-sierra: Move all reset_control_get*() to a separate function
    Date
    No functional change. Group devm_reset_control_get() and
    devm_reset_control_get_optional() to a separate function.

    Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
    ---
    drivers/phy/cadence/phy-cadence-sierra.c | 36 ++++++++++++++++--------
    1 file changed, 25 insertions(+), 11 deletions(-)

    diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/cadence/phy-cadence-sierra.c
    index 7bf1b4c7774a..935f165404e4 100644
    --- a/drivers/phy/cadence/phy-cadence-sierra.c
    +++ b/drivers/phy/cadence/phy-cadence-sierra.c
    @@ -509,6 +509,28 @@ static int cdns_sierra_phy_get_clocks(struct cdns_sierra_phy *sp,
    return 0;
    }

    +static int cdns_sierra_phy_get_resets(struct cdns_sierra_phy *sp,
    + struct device *dev)
    +{
    + struct reset_control *rst;
    +
    + rst = devm_reset_control_get(dev, "sierra_reset");
    + if (IS_ERR(rst)) {
    + dev_err(dev, "failed to get reset\n");
    + return PTR_ERR(rst);
    + }
    + sp->phy_rst = rst;
    +
    + rst = devm_reset_control_get_optional(dev, "sierra_apb");
    + if (IS_ERR(rst)) {
    + dev_err(dev, "failed to get apb reset\n");
    + return PTR_ERR(rst);
    + }
    + sp->apb_rst = rst;
    +
    + return 0;
    +}
    +
    static int cdns_sierra_phy_probe(struct platform_device *pdev)
    {
    struct cdns_sierra_phy *sp;
    @@ -559,17 +581,9 @@ static int cdns_sierra_phy_probe(struct platform_device *pdev)
    if (ret)
    return ret;

    - sp->phy_rst = devm_reset_control_get(dev, "sierra_reset");
    - if (IS_ERR(sp->phy_rst)) {
    - dev_err(dev, "failed to get reset\n");
    - return PTR_ERR(sp->phy_rst);
    - }
    -
    - sp->apb_rst = devm_reset_control_get_optional(dev, "sierra_apb");
    - if (IS_ERR(sp->apb_rst)) {
    - dev_err(dev, "failed to get apb reset\n");
    - return PTR_ERR(sp->apb_rst);
    - }
    + ret = cdns_sierra_phy_get_resets(sp, dev);
    + if (ret)
    + return ret;

    ret = clk_prepare_enable(sp->clk);
    if (ret)
    --
    2.17.1
    \
     
     \ /
      Last update: 2020-12-24 12:20    [W:5.914 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site