lkml.org 
[lkml]   [2020]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] clocksource: clint: Avoid remove __iomem in get_cycles_hi()
From
On Wed, 23 Dec 2020 00:23:30 PST (-0800), Christoph Hellwig wrote:
> On Mon, Dec 21, 2020 at 09:32:30PM -0800, Palmer Dabbelt wrote:
>> From: Palmer Dabbelt <palmerdabbelt@google.com>
>>
>> This cast loses the __iomem qualifier from clint_timer_val, which
>> triggers an sparse warning.
>
> I'm not a native speaker, but the subject line sounds strange to me.
> Shouldn't this be:
>
> "don't cast away the __iommu annotation"
>
> or something similar?

The title is also nonsense, I was probably trying to do two things at once when
I wrote this. I'll send another one.

> Also this adds an overly long line. Otherwise it looks fine.

Aren't we OK with lines longer than 80 characters now? Or was that some other
project? checkpatch doesn't complain, which I guess is why I didn't notice, so
hopefully that means I'm not crazy (though I guess the commit message and title
don't provide the best argument there... ;)).

\
 
 \ /
  Last update: 2020-12-24 04:01    [W:1.016 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site