lkml.org 
[lkml]   [2020]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] enic: Remove redundant free in enic_set_ringparam
On Wed, 23 Dec 2020 20:38:33 +0800 Dinghao Liu wrote:
> The error handling paths in enic_alloc_vnic_resources()
> have called enic_free_vnic_resources() before returning.
> So we may not need to call it again on failure at caller
> side.
>
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>

But it's harmless, right? So the patch is just a cleanup not a fix?

In that case, could you please repost in two weeks? We're currently
in the merge window period, we're only accepting fixes to the
networking trees.

Thanks!

\
 
 \ /
  Last update: 2020-12-23 21:40    [W:0.031 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site