Messages in this thread | | | Subject | Re: [PATCH v13 4/6] powerpc: Delete unused function delete_fdt_mem_rsv() | From | Lakshmi Ramasubramanian <> | Date | Tue, 22 Dec 2020 21:09:19 -0800 |
| |
On 12/22/20 5:08 PM, Thiago Jung Bauermann wrote: > > Lakshmi Ramasubramanian <nramas@linux.microsoft.com> writes: > >> delete_fdt_mem_rsv() defined in "arch/powerpc/kexec/file_load.c" >> has been renamed to fdt_find_and_del_mem_rsv(), and moved to >> "drivers/of/kexec.c". >> >> Remove delete_fdt_mem_rsv() in "arch/powerpc/kexec/file_load.c". >> >> Co-developed-by: Prakhar Srivastava <prsriva@linux.microsoft.com> >> Signed-off-by: Prakhar Srivastava <prsriva@linux.microsoft.com> >> Signed-off-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com> >> --- >> arch/powerpc/include/asm/kexec.h | 1 - >> arch/powerpc/kexec/file_load.c | 32 -------------------------------- >> 2 files changed, 33 deletions(-) > > As I mentioned in the other email, this patch could remove > setup_new_fdt() as well. > > I'm a bit ambivalent on whether this patch should be squashed with > patch 2 or left on its own, but I tend toward the latter option because > patch 2 is big enough already. >
I also think Patch #2 is already big enough - I don't want to make more changes in that patch.
I will remove delete_fdt_mem_rsv() and setup_new_fdt() in this patch (Patch #4) and call of_kexec_setup_new_fdt() directly (in setup_new_fdt_ppc64()).
thanks, -lakshmi
| |