Messages in this thread Patch in this message | | | From | Radhey Shyam Pandey <> | Subject | [PATCH v2 1/3] dmaengine: xilinx_dma: check dma_async_device_register return value | Date | Wed, 23 Dec 2020 16:51:00 +0530 |
| |
From: Shravya Kumbham <shravya.kumbham@xilinx.com>
dma_async_device_register() can return non-zero error code. Add condition to check the return value of dma_async_device_register function and handle the error path.
Addresses-Coverity: Event check_return. Fixes: 9cd4360de609 ("dma: Add Xilinx AXI Video Direct Memory Access Engine driver support") Signed-off-by: Shravya Kumbham <shravya.kumbham@xilinx.com> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com> --- Changes for v2: - Include fixes tag. --- drivers/dma/xilinx/xilinx_dma.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c index 993297d585c0..e41435be5b79 100644 --- a/drivers/dma/xilinx/xilinx_dma.c +++ b/drivers/dma/xilinx/xilinx_dma.c @@ -3133,7 +3133,11 @@ static int xilinx_dma_probe(struct platform_device *pdev) } /* Register the DMA engine with the core */ - dma_async_device_register(&xdev->common); + err = dma_async_device_register(&xdev->common); + if (err) { + dev_err(xdev->dev, "failed to register the dma device\n"); + goto error; + } err = of_dma_controller_register(node, of_dma_xilinx_xlate, xdev); -- 2.7.4
| |