lkml.org 
[lkml]   [2020]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/3] vfs: Add a super block operation to check for writeback errors
    On Mon, Dec 21, 2020 at 02:50:54PM -0500, Vivek Goyal wrote:
    > - ret2 = errseq_check_and_advance(&sb->s_wb_err, &f.file->f_sb_err);
    > + if (sb->s_op->errseq_check_advance)
    > + ret2 = sb->s_op->errseq_check_advance(sb, f.file);

    What a terrible name for an fs operation. You don't seem to be able
    to distinguish between semantics and implementation. How about
    check_error()?

    \
     
     \ /
      Last update: 2020-12-22 17:20    [W:4.187 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site