Messages in this thread | | | Subject | Re: [PATCH v4 2/2] firmware: arm_scmi: Augment SMC/HVC to allow optional interrupt | From | Florian Fainelli <> | Date | Tue, 22 Dec 2020 19:37:22 -0800 |
| |
On 12/22/2020 6:56 AM, Jim Quinlan wrote: > The SMC/HVC SCMI transport is modified to allow the completion of an SCMI > message to be indicated by an interrupt rather than the return of the smc > call. This accommodates the existing behavior of the BrcmSTB SCMI > "platform" whose SW is already out in the field and cannot be changed. > > Signed-off-by: Jim Quinlan <jim2101024@gmail.com>
This looks good to me, just one question below:
[snip]
> @@ -111,6 +145,8 @@ static int smc_send_message(struct scmi_chan_info *cinfo, > shmem_tx_prepare(scmi_info->shmem, xfer); > > arm_smccc_1_1_invoke(scmi_info->func_id, 0, 0, 0, 0, 0, 0, 0, &res); > + if (scmi_info->irq) > + wait_for_completion(&scmi_info->tx_complete);
Do we need this to have a preceding call to reinit_completion()? It does not look like this is going to make any practical difference but there are drivers doing that for correctness. -- Florian
| |