lkml.org 
[lkml]   [2020]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 043/130] media: usb: dvb-usb-v2: zd1301: fix missing platform_device_unregister()
    Date
    From: Qinglang Miao <miaoqinglang@huawei.com>

    [ Upstream commit ee50d6e60d9a8e110e984cdd9e788d93eff540ba ]

    Add the missing platform_device_unregister() before return
    from zd1301_frontend_attach in the error handling case when
    pdev->dev.driver is empty.

    There's an error handling route named err_platform_device_unregister,
    so just reuse it.

    Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
    Signed-off-by: Sean Young <sean@mess.org>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/usb/dvb-usb-v2/zd1301.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/media/usb/dvb-usb-v2/zd1301.c b/drivers/media/usb/dvb-usb-v2/zd1301.c
    index 63b66b207b64d..815ae1e8dc03e 100644
    --- a/drivers/media/usb/dvb-usb-v2/zd1301.c
    +++ b/drivers/media/usb/dvb-usb-v2/zd1301.c
    @@ -150,7 +150,7 @@ static int zd1301_frontend_attach(struct dvb_usb_adapter *adap)
    }
    if (!pdev->dev.driver) {
    ret = -ENODEV;
    - goto err;
    + goto err_platform_device_unregister;
    }
    if (!try_module_get(pdev->dev.driver->owner)) {
    ret = -ENODEV;
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-12-23 04:02    [W:4.717 / U:0.320 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site