lkml.org 
[lkml]   [2020]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v10 09/11] mm/hugetlb: Introduce nr_free_vmemmap_pages in the struct hstate
    On Thu, Dec 17, 2020 at 08:13:01PM +0800, Muchun Song wrote:
    > @@ -182,6 +184,12 @@ bool hugetlb_free_vmemmap_enabled;
    >
    > static int __init early_hugetlb_free_vmemmap_param(char *buf)
    > {
    > + /* We cannot optimize if a "struct page" crosses page boundaries. */
    > + if ((!is_power_of_2(sizeof(struct page)))) {
    > + pr_warn("cannot free vmemmap pages because \"struct page\" crosses page boundaries\n");
    > + return 0;
    > + }

    Unless there is a strong reason behind, I would move this to the previous patch,
    where early_hugetlb_free_vmemmap_param is introduced.

    --
    Oscar Salvador
    SUSE L3

    \
     
     \ /
      Last update: 2020-12-21 09:18    [W:5.216 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site