Messages in this thread | | | Subject | Re: [PATCH v5 01/11] firmware: raspberrypi: Keep count of all consumers | From | Florian Fainelli <> | Date | Wed, 2 Dec 2020 09:26:15 -0800 |
| |
On 11/23/2020 10:38 AM, Nicolas Saenz Julienne wrote: > When unbinding the firmware device we need to make sure it has no > consumers left. Otherwise we'd leave them with a firmware handle > pointing at freed memory. > > Keep a reference count of all consumers and introduce rpi_firmware_put() > which will permit automatically decrease the reference count upon > unbinding consumer drivers. > > Suggested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
This looks fine to me, just one nit below:
[snip]
> /** > - * rpi_firmware_get - Get pointer to rpi_firmware structure.
Is not removing this line going to create a kernel doc warning?
With that fixed:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
| |