lkml.org 
[lkml]   [2020]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] keys: remove trailing semicolon in macro definition
On Sat, Nov 28, 2020 at 09:30:44PM -0800, Joe Perches wrote:
> On Sun, 2020-11-29 at 06:45 +0200, Jarkko Sakkinen wrote:
> > On Fri, Nov 27, 2020 at 11:15:43AM -0800, trix@redhat.com wrote:
> > > From: Tom Rix <trix@redhat.com>
> > >
> > > The macro use will already have a semicolon.
> > >
> > > Signed-off-by: Tom Rix <trix@redhat.com>
> >
> > I'm in-between whether this is worth of merging. The commit message
> > does not help with that decision too much.
>
> It seems worthy of merging to me modulo whatver improvement is desired in
> the commit message.
>
> There are 3 existing uses of request_key_net. All have a trailing semicolon.
> There is 1 existing use of request_key_net_rcu. It has a trailing semicolon.
>
> No object change should occur.

OK, makes sense.

Acked-by: Jarkko Sakkinen <jarkko@kernel.org>

/Jarkko

\
 
 \ /
  Last update: 2020-12-02 17:49    [W:0.031 / U:1.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site