lkml.org 
[lkml]   [2020]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [RFC 1/2] perf core: Add PERF_COUNT_SW_CGROUP_SWITCHES event
    On Wed, Dec 2, 2020 at 2:42 PM Andi Kleen <ak@linux.intel.com> wrote:
    >
    > On Wed, Dec 02, 2020 at 11:47:25AM -0800, Stephane Eranian wrote:
    > > On Wed, Dec 2, 2020 at 11:28 AM Andi Kleen <ak@linux.intel.com> wrote:
    > > >
    > > > > + prev_cgrp = task_css_check(prev, perf_event_cgrp_id, 1)->cgroup;
    > > > > + next_cgrp = task_css_check(next, perf_event_cgrp_id, 1)->cgroup;
    > > > > +
    > > > > + if (prev_cgrp != next_cgrp)
    > > > > + perf_sw_event_sched(PERF_COUNT_SW_CGROUP_SWITCHES, 1, 0);
    > > >
    > > > Seems to be the perf cgroup only, not all cgroups.
    > > > That's a big difference and needs to be documented properly.
    > > >
    > > We care about the all-cgroup case.
    >
    > Then it's not correct I think. You need a different hook point.
    >
    I realize that ;-(

    \
     
     \ /
      Last update: 2020-12-03 00:43    [W:3.766 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site