lkml.org 
[lkml]   [2020]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net v2] bonding: fix feature flag setting at init time
On Wed, 2 Dec 2020 14:03:53 -0500 Jarod Wilson wrote:
> On Wed, Dec 2, 2020 at 12:53 PM Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > On Wed, 2 Dec 2020 12:30:53 -0500 Jarod Wilson wrote:
> > > + if (bond->dev->reg_state != NETREG_REGISTERED)
> > > + goto noreg;
> > > +
> > > if (newval->value == BOND_MODE_ACTIVEBACKUP)
> > > bond->dev->wanted_features |= BOND_XFRM_FEATURES;
> > > else
> > > bond->dev->wanted_features &= ~BOND_XFRM_FEATURES;
> > > - netdev_change_features(bond->dev);
> > > + netdev_update_features(bond->dev);
> > > +noreg:
> >
> > Why the goto?
>
> Seemed cleaner to prevent an extra level of indentation of the code
> following the goto and before the label, but I'm not that attached to
> it if it's not wanted for coding style reasons.

Yes, please don't use gotos where a normal if statement is sufficient.
If you must avoid the indentation move the code to a helper.

Also - this patch did not apply to net, please make sure you're
developing on the correct base.

\
 
 \ /
  Last update: 2020-12-02 20:24    [W:0.225 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site