Messages in this thread | | | From | Linus Torvalds <> | Date | Fri, 18 Dec 2020 09:54:45 -0800 | Subject | Re: [PATCH] gcc-plugins: simplify GCC plugin-dev capability test |
| |
On Fri, Dec 18, 2020 at 7:33 AM Jon Hunter <jonathanh@nvidia.com> wrote: > > However, if you are saying that this is a problem/bug with our builders, > then of course we will have to get this fixed.
This seems to be a package dependency problem with the gcc plugins - they clearly want libgmp, but apparently the package hasn't specified that dependency.
If this turns out to be a big problem, I guess we can't simplify the plugin check after all.
We historically just disabled gcc-plugins if that header didn't build, which obviously meant that it "worked" for people, but it also means that clearly the coverage can't have been as good as it could/should be.
So if it's as simple as just installing the GNU multiprecision libraries ("gmp-devel" on most rpm-based systems, "libgmp-dev" on most debian systems), then I think that's the right thing to do. You'll get a working build again, and equally importantly, your build servers will actually do a better job of covering the different build options.
Linus
| |