Messages in this thread | | | Subject | Re: [PATCH -V6 RESEND 2/3] NOT kernel/man-pages: man2/set_mempolicy.2: Add mode flag MPOL_F_NUMA_BALANCING | From | "Alejandro Colomar (mailing lists; readonly)" <> | Date | Fri, 18 Dec 2020 11:21:05 +0100 |
| |
Hi Huang, Ying,
Sorry I forgot to answer. See below.
BTW, Linux 5.10 has been released recently; is this series already merged for 5.11? If not yet, could you just write '5.??' and we'll fix it (and add a commit number in a comment) when we know the definitive version?
Thanks,
Alex
On 12/8/20 9:13 AM, Huang, Ying wrote: > Hi, Alex, > > Sorry for late, I just notice this email today. > > "Alejandro Colomar (mailing lists; readonly)" > <alx.mailinglists@gmail.com> writes: > >> Hi Huang Ying, >> >> Please see a few fixes below. >> >> Michael, as always, some question for you too ;) >> >> Thanks, >> >> Alex >> >> On 12/2/20 9:42 AM, Huang Ying wrote: >>> Signed-off-by: "Huang, Ying" <ying.huang@intel.com> >>> --- >>> man2/set_mempolicy.2 | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/man2/set_mempolicy.2 b/man2/set_mempolicy.2 >>> index 68011eecb..3754b3e12 100644 >>> --- a/man2/set_mempolicy.2 >>> +++ b/man2/set_mempolicy.2 >>> @@ -113,6 +113,12 @@ A nonempty >>> .I nodemask >>> specifies node IDs that are relative to the set of >>> node IDs allowed by the process's current cpuset. >>> +.TP >>> +.BR MPOL_F_NUMA_BALANCING " (since Linux 5.11)" >> >> I'd prefer it to be in alphabetical order (rather than just adding at >> the bottom). > > That's OK for me. But it's better to be done in another patch to > distinguish contents from pure order change?
Yes, if you could do a series of 2 patches with a reordering first, it would be great.
> >> That way, when lists grow, it's easier to find things. >> >>> +Enable the Linux kernel NUMA balancing for the task if it is supported >>> +by kernel. >> >> I'd s/Linux kernel/kernel/ when it doesn't specifically refer to the >> Linux kernel to differentiate it from other kernels. It only adds noise >> (IMHO). mtk? > > Sure. Will fix this and all following comments below. Thanks a lot for > your help! I am new to man pages.
Thank you!
> > Best Regards, > Huang, Ying >
| |