Messages in this thread | | | Subject | Re: [PATCH v4 09/10] selftests/vm: test flag is broken | From | John Hubbard <> | Date | Fri, 18 Dec 2020 01:11:00 -0800 |
| |
On 12/18/20 1:06 AM, John Hubbard wrote: >> Add a new test_flags field, to allow raw gup_flags to work. > > I think .test_control_flags field would be a good name, to make it very > clear that it's not destined for gup_flags. Just .test_flags is not quite > as clear a distinction from .gup_flags, as .test_control_flags is, IMHO. >
And maybe renaming .flags to .gup_flags, just to make it really clear.
thanks, -- John Hubbard NVIDIA
| |