lkml.org 
[lkml]   [2020]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 09/10] selftests/vm: test flag is broken
From
Date
On 12/18/20 1:06 AM, John Hubbard wrote:
>> Add a new test_flags field, to allow raw gup_flags to work.
>
> I think .test_control_flags field would be a good name, to make it very
> clear that it's not destined for gup_flags. Just .test_flags is not quite
> as clear a distinction from .gup_flags, as .test_control_flags is, IMHO.
>

And maybe renaming .flags to .gup_flags, just to make it really clear.


thanks,
--
John Hubbard
NVIDIA

\
 
 \ /
  Last update: 2020-12-18 10:15    [W:0.086 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site