Messages in this thread | | | Date | Thu, 17 Dec 2020 09:28:16 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH] atm: ambassador: remove h from printk format specifier |
| |
On Thu, 17 Dec 2020 05:17:24 -0800 Tom Rix wrote: > On 12/16/20 4:45 PM, Jakub Kicinski wrote: > > On Tue, 15 Dec 2020 06:22:28 -0800 trix@redhat.com wrote: > >> From: Tom Rix <trix@redhat.com> > >> > >> See Documentation/core-api/printk-formats.rst. > >> h should no longer be used in the format specifier for printk. > >> > >> Signed-off-by: Tom Rix <trix@redhat.com> > > That's for new code I assume? > > > > What's the harm in leaving this ancient code be? > > This change is part of a tree wide cleanup.
What's the purpose of the "clean up"? Why is it making the code better?
This is a quote from your change:
- PRINTK (KERN_NOTICE, "debug bitmap is %hx", debug &= DBG_MASK); + PRINTK (KERN_NOTICE, "debug bitmap is %x", debug &= DBG_MASK);
Are you sure that the use of %hx is the worst part of that line?
> drivers/atm status is listed as Maintained in MAINTAINERS so changes > like this should be ok. > > Should drivers/atm status be changed?
Up to Chas, but AFAIU we're probably only a few years away from ATM as a whole walking into the light. So IMHO "Obsolete" would be justified.
| |