Messages in this thread | | | Subject | Re: [PATCH v2] net: korina: fix return value | From | Florian Fainelli <> | Date | Wed, 16 Dec 2020 13:32:26 -0800 |
| |
On 12/16/20 12:43 PM, Jakub Kicinski wrote: > On Mon, 14 Dec 2020 23:09:52 +0100 Vincent Stehlé wrote: >> The ndo_start_xmit() method must not attempt to free the skb to transmit >> when returning NETDEV_TX_BUSY. Therefore, make sure the >> korina_send_packet() function returns NETDEV_TX_OK when it frees a packet. >> >> Fixes: ef11291bcd5f ("Add support the Korina (IDT RC32434) Ethernet MAC") >> Suggested-by: Jakub Kicinski <kuba@kernel.org> >> Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net> >> Cc: David S. Miller <davem@davemloft.net> >> Cc: Florian Fainelli <florian.fainelli@telecomint.eu> > > Let me CC Florian's more recent email just in case he wants to review.
Acked-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
| |