lkml.org 
[lkml]   [2020]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V2] scsi: ufs-debugfs: Add error counters
From
Date
On Wed, 2020-12-16 at 20:51 +0200, Adrian Hunter wrote:
> ufshcd_variant_hba_exit(hba);
> ufshcd_setup_vreg(hba, false);
> ufshcd_suspend_clkscaling(hba);
> @@ -9436,6 +9441,20 @@ int ufshcd_init(struct ufs_hba *hba, void
> __iomem *mmio_base, unsigned int irq)
> }
> EXPORT_SYMBOL_GPL(ufshcd_init);
>
> +static int __init ufshcd_core_init(void)
> +{
> + ufs_debugfs_init();
> + return 0;
> +}
> +
> +static void __exit ufshcd_core_exit(void)
> +{
> + ufs_debugfs_exit();
> +}

Hi, Adrian

The purpose of patch is acceptable, but I don't know why you choose
using ufshcd_core_* here.
Also. I don't know if module_init() is a proper way here.

thanks,
Bean

>
> n
> +
> +module_init(ufshcd_core_init);
> +module_exit(ufshcd_core_exit)

\
 
 \ /
  Last update: 2020-12-16 21:19    [W:0.061 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site