Messages in this thread | | | Date | Wed, 16 Dec 2020 17:04:47 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH v3 net-next 1/2] net: phy: mchp: Add interrupt support for Link up and Link down to LAN8814 phy |
| |
> +static irqreturn_t lan8814_handle_interrupt(struct phy_device *phydev) > +{ > + int irq_status; > + > + irq_status = phy_read(phydev, LAN8814_INTS); > + if (irq_status < 0) > + return IRQ_NONE; > + > + if (irq_status & LAN8814_INTS_ALL) > + phy_mac_interrupt(phydev);
This is a PHY driver, so it should not be using the MAC API call. Please change to
phy_trigger_machine(phydev);
Andrew
| |