Messages in this thread | | | Date | Wed, 16 Dec 2020 09:30:07 -0500 | From | Tejun Heo <> | Subject | Re: [PATCH 00/10] workqueue: break affinity initiatively |
| |
On Mon, Dec 14, 2020 at 11:54:47PM +0800, Lai Jiangshan wrote: > From: Lai Jiangshan <laijs@linux.alibaba.com> > > 06249738a41a ("workqueue: Manually break affinity on hotplug") > said that scheduler will not force break affinity for us. > > But workqueue highly depends on the old behavior. Many parts of the codes > relies on it, 06249738a41a ("workqueue: Manually break affinity on hotplug") > is not enough to change it, and the commit has flaws in itself too. > > We need to thoroughly update the way workqueue handles affinity > in cpu hot[un]plug, what is this patchset intends to do and > replace the Valentin Schneider's patch [1]. > > Patch 1 fixes a flaw reported by Hillf Danton <hdanton@sina.com>. > I have to include this fix because later patches depends on it. > > The patchset is based on tip/master rather than workqueue tree, > because the patchset is a complement for 06249738a41a ("workqueue: > Manually break affinity on hotplug") which is only in tip/master by now. > > [1]: https://lore.kernel.org/r/ff62e3ee994efb3620177bf7b19fab16f4866845.camel@redhat.com
Generally looks good to me. Please feel free to add
Acked-by: Tejun Heo <tj@kernel.org>
and route the series through tip.
Thanks.
-- tejun
| |