Messages in this thread | | | Date | Wed, 16 Dec 2020 14:27:42 +0100 | From | Jessica Yu <> | Subject | Re: static_branch_enable() does not work from a __init function? |
| |
+++ Peter Zijlstra [16/12/20 14:23 +0100]: >On Wed, Dec 16, 2020 at 02:10:16PM +0100, Jessica Yu wrote: >> +++ Peter Zijlstra [16/12/20 13:47 +0100]: > >> > Only because we're having .init=false, incorrectly. See the other email. >> >> Ah yeah, you're right. I also misread the intention of the if >> conditional :/ If we're currently running an init function it's fine, >> but after that it will be unsafe. > >Exactly, seeing how it'll end up being freed and such ;-) > >> Btw, your patch seems to work for me, using the test module provided >> by Dexuan. > >Ah, excellent. I couldn't be bothered to figure out how to build a >module ;-) > >I'll add your Tested-by and go queue it for /urgent I suppose.
That's fine by me :-)
Tested-by: Jessica Yu <jeyu@kernel.org>
| |