Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Wed, 16 Dec 2020 13:36:22 +0100 | Subject | Re: [PATCH] spi: Fix the clamping of spi->max_speed_hz |
| |
On Wed, Dec 16, 2020 at 10:23 AM Tudor Ambarus <tudor.ambarus@microchip.com> wrote: > If spi->controller->max_speed_hz is zero, a non-zero spi->max_speed_hz > will be overwritten by zero. Make sure spi->controller->max_speed_hz > is not zero when clamping spi->max_speed_hz. > > Put the spi->controller->max_speed_hz non-zero check higher in the if, > so that we avoid a superfluous init to zero when both spi->max_speed_hz > and spi->controller->max_speed_hz are zero. > > Fixes: 9326e4f1e5dd ("spi: Limit the spi device max speed to controller's max speed") > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |