Messages in this thread Patch in this message | | | Subject | Re: [PATCH] atm: horizon: remove h from printk format specifier | From | Joe Perches <> | Date | Tue, 15 Dec 2020 12:13:51 -0800 |
| |
On Tue, 2020-12-15 at 06:24 -0800, trix@redhat.com wrote: > From: Tom Rix <trix@redhat.com> > > See Documentation/core-api/printk-formats.rst. > h should no longer be used in the format specifier for printk. > > Signed-off-by: Tom Rix <trix@redhat.com> > --- > drivers/atm/horizon.c | 6 +++---
Chas?
Madge has been out of business for a couple decades now.
I doubt anyone does but does anyone actually use this driver or even have working hardware?
If not, how about just deleting this driver altogether instead?
from horizon.h:
/* Madge Horizon ATM Adapter driver. Copyright (C) 1995-1999 Madge Networks Ltd.
*/
/* IMPORTANT NOTE: Madge Networks no longer makes the adapters supported by this driver and makes no commitment to maintain it. */
> diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c [] > @@ -1609,7 +1609,7 @@ static int hrz_send (struct atm_vcc * atm_vcc, struct sk_buff * skb) { > if (*s++ == 'D') { > for (i = 0; i < 4; ++i) > d = (d << 4) | hex_to_bin(*s++); > - PRINTK (KERN_INFO, "debug bitmap is now %hx", debug = d); > + PRINTK (KERN_INFO, "debug bitmap is now %x", debug = d);
An IMO ugly assignment in a printk too.
| |