Messages in this thread | | | Date | Tue, 15 Dec 2020 11:14:55 -0600 | From | Rob Herring <> | Subject | Re: [PATCH 02/25] dt-bindings: net: dwmac: Extend number of PBL values |
| |
On Mon, 14 Dec 2020 12:15:52 +0300, Serge Semin wrote: > In accordance with [1] the permitted PBL values can be set as one of > [1, 2, 4, 8, 16, 32]. The rest of the values results in undefined > behavior. At the same time some of the permitted values can be also > invalid depending on the controller FIFOs size and the data bus width. > Seeing due to having too many variables all the possible PBL property > constraints can't be implemented in the bindings schema, let's extend > the set of permitted PBL values to be as much as the configuration > register supports leaving the undefined behaviour cases for developers > to handle. > > [1] DesignWare Cores Ethernet MAC Universal Databook, Revision 3.73a, > October 2013, p. 380. > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > --- > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) >
Reviewed-by: Rob Herring <robh@kernel.org>
| |